Looks good, Reviewed-by: Christoph Hellwig <hch at lst.de> minor nitpick below: > +reread: > + bp = xfs_buf_read_uncached(mp, mp->m_ddev_targp, XFS_SB_DADDR, sector_size); Too long line.