[PATCH 08/18] xfs: rename xfs_buf_get_nodaddr to be more appropriate

Christoph Hellwig hch at infradead.org
Tue Sep 14 09:56:17 CDT 2010


>  xfs_buf_t *
> -xfs_buf_get_noaddr(
> +xfs_buf_get_uncached(
>  	size_t			len,
>  	xfs_buftarg_t		*target)
>  {
> @@ -725,7 +725,7 @@ xfs_buf_get_noaddr(
>  		goto fail_free_buf;
>  
>  	for (i = 0; i < page_count; i++) {
> -		bp->b_pages[i] = alloc_page(GFP_KERNEL);
> +		bp->b_pages[i] = alloc_page(GFP_NOFS);

Instead of doingthis unconditionally I think it's better to add a flags
aregument which can contain XBF_DONT_BLOCK, and then use xb_to_gfp for
the flags.




More information about the xfs mailing list