[PATCH 4/4] xfs: convert buffer cache hash to rbtree
Alex Elder
aelder at sgi.com
Mon Sep 13 11:59:45 CDT 2010
> > @@ -210,8 +210,6 @@ xfs_perag_get(struct xfs_mount *mp, xfs_agnumber_t agno)
> > pag = radix_tree_lookup(&mp->m_perag_tree, agno);
> > if (pag) {
> > ASSERT(atomic_read(&pag->pag_ref) >= 0);
> > - /* catch leaks in the positive direction during testing */
> > - ASSERT(atomic_read(&pag->pag_ref) < 1000);
>
> Di you manage to hit this during testing? Either way it should probably
> be a separate patch.
I'm pretty sure this is due to each buffer now holding
a perag reference. It might be nice to preserve this
functionality by checking against the number of blocks
in the AG or something similar. But it's debug so it's
not quite as critical.
-Alex
More information about the xfs
mailing list