[PATCH] xfstests: use a common _filter_test_dir function

Christoph Hellwig hch at infradead.org
Mon Oct 25 08:45:43 CDT 2010


On Fri, Oct 22, 2010 at 09:09:24AM -0500, Alex Elder wrote:
> Christoph Hellwig suggested that a function similar to the common
> "_filter_scratch" function ought to be created to handle filtering
> of the TEST_DIR and TEST_DEV variables.  This patch implements that.
> 
> The name "_filter_test" seems like it might suggest it does
> something different, so I'm calling this one "_filter_test_dir".
> This unfortunately makes the "test" and "scratch" functions have
> different naming conventions, but I guess we should be accustomed
> to that by now (consider "TEST_DIR" and "SCRATCH_MNT").
> 
> Signed-off-by: Alex Elder <aelder at sgi.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>




More information about the xfs mailing list