[PATCH 06/10] xfs: simplify xfs_map_blocks
Dave Chinner
david at fromorbit.com
Tue Nov 30 22:41:31 CST 2010
On Mon, Nov 22, 2010 at 08:05:12AM -0500, Christoph Hellwig wrote:
> No need to lock the extent map exclusive when performing an overwrite,
> we know the extent map must already have been loaded by get_blocks.
> Apply the non-blocking inode semantics to all mapping types instead of
> just delayed allocations. Remove the handling of not yet allocated
> blocks for the IO_UNWRITTEN case - if an extent is marked as delayed
> allocated in the buffer it must already have an extent on disk.
I think your meant "marked as unwritten in the buffer" there.
> Add asserts to verify all the assumptions above in debug builds.
Nice - I would have asked that to be added ;)
> Signed-off-by: Christoph Hellwig <hch at lst.de>
Looks good. It is much simpler now.
Reviewed-by: Dave Chinner <dchinner at redhat.com>
--
Dave Chinner
david at fromorbit.com
More information about the xfs
mailing list