[PATCH 04/10] xfs: cleanup the xfs_iomap_write_* helpers

Dave Chinner david at fromorbit.com
Tue Nov 30 22:11:02 CST 2010


On Mon, Nov 22, 2010 at 08:05:10AM -0500, Christoph Hellwig wrote:
> Remove passing the BMAPI_* flags to these helpers, in xfs_iomap_write_direct
> the check BMAPI_DIRECT was always true, and in the xfs_iomap_write_delay
> path is was never checked at all.  Remove the nmap return value as
> we never make use of it.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Makes sense - fewer useless parameters being passed around is good...

Reviewed-by: Dave Chinner <dchinner at redhat.com>
-- 
Dave Chinner
david at fromorbit.com




More information about the xfs mailing list