[PATCH 1/3] lib: percpu counter add unless less than functionality

Peter Zijlstra a.p.zijlstra at chello.nl
Mon Nov 29 06:08:50 CST 2010


On Mon, 2010-11-29 at 11:36 +1100, Dave Chinner wrote:
> +int percpu_counter_add_unless_lt(struct percpu_counter *fbc, s64 amount,
> +                                                       s64 threshold);

It might make sense to implement that as;

  __percpu_counter_add_unless_lt(struct percpu_counter *fbc,
				 s64 amount,
				 s64 threshold,
				 s32 batch);

That way its consistent with the __percpu_counter_add() implementation
where you can also specify the batch value.





More information about the xfs mailing list