[PATCH] xfs: fix exporting with left over 64-bit inodes

Samuel Kvasnica samuel.kvasnica at ims.co.at
Mon Nov 22 03:05:27 CST 2010


On 11/22/2010 01:37 AM, Dave Chinner wrote:
> On Fri, Nov 19, 2010 at 08:38:49AM -0500, Christoph Hellwig wrote:
>> From: Samuel Kvasnica <samuel.kvasnica at ims.co.at>
>>
>> We now support mounting and using filesystems with 64-bit inodes even
>> when not mounted with the inode64 option (which now only controls if
>> we allocate new inodes in that space or not).  Make sure we always
>> use large NFS file handles when exporting a filesystem that may contain
>> 64-bit inodes.  Note that this only affects newly generated file handles,
>> any outstanding 32-bit file handle is still accepted.
>>
>> [hch: the comment and commit log are mine, the rest is from a patch
>>  snipplet from Samuel]
>>
>> Signed-off-by: Christoph Hellwig <hch at lst.de>
> Won't this mean that people exporting non-root directories suddenly
> have those exports stop working on a kernel upgrade due to changing
> the handle format?
>
> Cheers,
>
> Dave.
Hello Dave,

nothing is really changing, it is a bugfix. NFS was trying to use 32bit
inodes which was incorrect (i.e. broken at client) for xfs filesystem
containing 64bit inodes in one special case. This is fixed now.

regards,

Sam





More information about the xfs mailing list