[PATCH 01/16] xfs: fix per-ag reference counting in inode reclaim tree walking

Christoph Hellwig hch at infradead.org
Mon Nov 8 03:23:52 CST 2010


> +++ b/fs/xfs/linux-2.6/xfs_sync.c
> @@ -853,6 +853,7 @@ restart:
>  		if (trylock) {
>  			if (!mutex_trylock(&pag->pag_ici_reclaim_lock)) {
>  				skipped++;
> +				xfs_perag_put(pag);
>  				continue;
>  			}
>  			first_index = pag->pag_ici_reclaim_cursor;

One way to make this loop more maintainable is to split the guts of it
into a xfs_reclaim_inodes_ag helper, and make the existing function a
wrapper around it (and remove the incorrect _ag prefix), but that's .38
material.

For .37 the patch looks good,


Reviewed-by: Christoph Hellwig <hch at lst.de>




More information about the xfs mailing list