[PATCH] xfs: fix might_sleep() warning when initialising per-ag tree

Christoph Hellwig hch at infradead.org
Thu May 27 07:21:49 CDT 2010


On Thu, May 27, 2010 at 11:58:13AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> The use of radix_tree_preload() only works if the radix tree was initialised
> without the __GFP_WAIT flag. The per-ag tree uses GFP_NOFS, so does not trigger
> allocation of new tree nodes from the preloaded array. Hence it enters the
> allocator with a spinlock held and triggers the might_sleep() warnings.
> 
> Reported-by; Chris Mason <chris.mason at oracle.com>
> Signed-off-by: Dave Chinner <dchinner at redhat.com>

Looks good,


Reviewed-by: Christoph Hellwig <hch at lst.de>




More information about the xfs mailing list