[PATCH 6/7] xfs: nothing special about 1-block log sector

[Christoph Hellwig]

> +	/*
> +	 * We do log I/O in units of log sectors (a power-of-2
> +	 * multiple of the basic block size), so we round up the
> +	 * requested size to acommodate the basic blocks required
> +	 * for complete log sectors.
> +	 *
> +	 * In addition, the buffer may be used for a non-sector-
> +	 * aligned block offset, in which case an I/O of the
> +	 * requested size could extend beyond the end of the
> +	 * buffer.  If the requested size is only 1 basic block it
> +	 * will never straddle a sector boundary, so this won't be
> +	 * an issue.  Nor will this be a problem if the log I/O is
> +	 * done in basic blocks (sector size 1).  But otherwise we
> +	 * extend the buffer by one extra log sector to ensure
> +	 * there's space to accomodate this possiblility.
> +	 */


Ah, you're adding the comment that I asked a few patches ago here,
great!

The patch looks good,


Reviewed-by: Christoph Hellwig <hch at lst.de>