[Security] XFS swapext ioctl minor security issues

Christoph Hellwig hch at infradead.org
Thu Jun 17 06:40:51 CDT 2010


On Wed, Jun 16, 2010 at 09:57:35AM -0400, Dan Rosenberg wrote:
> I removed the part of the patch dealing with suid/sgid bits - your
> reasoning seems good, we clearly don't want to just drop the suid/sgid
> bits. ?I was just trying to point out the case where the caller is not
> the owner and has write access to the file; since in the ordinary case
> writing to that file would result in dropping the suid bit, I thought
> this ioctl should try to replicate that behavior.

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>

Alex, can you push it to Linus ASAP?




More information about the xfs mailing list