[PATCH 3/3] xfs: simplify xfs_vm_writepage

Dave Chinner david at fromorbit.com
Mon Jun 14 20:50:47 CDT 2010


On Fri, Jun 11, 2010 at 12:13:15PM -0400, Christoph Hellwig wrote:
> The writepage implementation in XFS still tries to deal with dirty but
> unmapped buffers which used to caused by writes through shared mmaps.  Since
> the introduction of ->page_mkwrite these can't happen anymore, so remove the
> code dealing with them.
> 
> Note that the all_bh variable which causes us to start I/O on all buffers on
> the pages was controlled by the count of unmapped buffers, which also
> included those not actually dirty.  It's now unconditionally initialized to
> 0 but set to 1 for the case of small file size extensions.  It probably can
> be removed entirely, but that's left for another patch.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Looks good.

Reviewed-by: Dave Chinner <dchinner at redhat.com>

-- 
Dave Chinner
david at fromorbit.com




More information about the xfs mailing list