[PATCH V3] xfstests: use stat not lstat when examining devices

Eric Sandeen sandeen at sandeen.net
Tue Jun 8 11:06:23 CDT 2010


Alex Elder wrote:
> On Fri, 2010-06-04 at 13:00 -0500, Eric Sandeen wrote:
>> If you try running xfstests on lvm volumes which are symlinks,
>> it'll fail to run several tests because our _require_scratch 
>> framework ultimately uses lstat not stat, and does not think 
>> the lvm device (which is usually a symlink to a dm-X device) 
>> is a block device.  Sigh.
>>
>> Just calling stat(1) with -L to follow the link should
>> suffice.
> 
> I wonder whether we'll find stat(1) output ever varies
> enough to affect this.
> 
> But otherwise this looks good to me.
> 
> Reviewed-by: Alex Elder <aelder at sgi.com>
> 
>> Signed-off-by: Eric Sandeen <sandeen at sandeen.net>

Sorry, after all that I'm retracting this patch.  mount, /proc/mounts,
/etc/mtab etc just get very confused when using symlinked devices,
at least as xfstests wants to use them.

For now I'll just make my uber-harness resolve symlinks to the real
device (maybe that could be done in xfstests at some point)

-Eric




More information about the xfs mailing list