[PATCH 6/8] xfs: fix unsigned underflow

Dave Chinner david at fromorbit.com
Tue Jul 20 18:12:01 CDT 2010


On Tue, Jul 20, 2010 at 02:35:33PM -0500, Alex Elder wrote:
> On Thu, 2010-07-15 at 17:21 -0400, Christoph Hellwig wrote:
> > On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote:
> > > map_len is unsigned. Checking map_len <= 0 is buggy when it should be
> > > below zero. So, check exact expression instead of map_len.
> > > 
> > > Signed-off-by: Kulikov Vasiliy <segooon at gmail.com>
> > 
> > Looks good,
> > 
> > Reviewed-by: Christoph Hellwig <hch at lst.de>
> > 
> 
> Looks good to me too.  Do you want me to pull this
> in via the XFS tree, or do you have other plans?

Already got it, Alex.

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com




More information about the xfs mailing list