[PATCH 3/5] xfs: fix xfs_trans_add_item() lockdep warnings

Christoph Hellwig hch at infradead.org
Fri Jul 16 00:19:34 CDT 2010


> -	lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP);
> +	lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP|KM_NOFS);

KM_NOFS by itself actually is sufficiant.  If you want to keep the
KM_SLEEP for documentation purposes at least add some spaces to make
it more redable.

	lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP | KM_NOFS);

Once getting outside of nitpicking territory this looks good to me:


Reviewed-by: Christoph Hellwig <hch at lst.de>




More information about the xfs mailing list