[PATCH 1/2] xfs: don't block on buffer read errors
Christoph Hellwig
hch at infradead.org
Wed Jul 14 13:28:36 CDT 2010
Looks good, except that I'd rework the snipplet below
> status = xfs_buf_iorequest(bp);
> - if (!status && !(flags & XBF_ASYNC))
> + if (!(status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC)))
> status = xfs_buf_iowait(bp);
> return status;
as:
if (status || XFS_BUF_ISERROR(bp) || (flags & XBF_ASYNC))
return status;
return xfs_buf_iowait(bp);
to make it a bit more clear.
More information about the xfs
mailing list