[PATCH] xfstests: 223 - test file alignment on stripe geometry

Christoph Hellwig hch at infradead.org
Sat Jan 30 13:09:35 CST 2010


> didn't break anything for me; I wanted to be able to see the mkfs
> results w/ geometry, is all.  Will re-double-check but it was fine AFAIK.

Yeah, doesn't seem to cause any problems with a full xfsqa run for me.

> > This is a bit misnamed as it's not a generic fibmap tool but rather
> > a specific tool comparing the bmap to the sunit alignment.
> > 
> 
> good point .. how about making it more generic, something like:
> 
> fibmap -o <file offset> -l <length> -s <stripe alignment> <filename>
> 
> hmm though I hate to reqwrite filefrag ... :)
> 
> I suppose something like this could go into xfs_io as well, but that
> makes this test unavailable to the masses until another release, at least.

I'd just leave it as is but call it t_stripealign or similar.




More information about the xfs mailing list