[PATCH 5/7] xfs: Use delay write promotion for dquot flushing

Christoph Hellwig hch at infradead.org
Mon Jan 25 06:03:14 CST 2010


On Mon, Jan 25, 2010 at 05:22:42PM +1100, Dave Chinner wrote:
> xfs_qm_dqflock_pushbuf_wait() does a very similar trick to item
> pushing used to do to flush out delayed write dquot buffers. Change
> it to use the new promotion method rather than an async flush.
> 
> Also, xfs_qm_dqflock_pushbuf_wait() can return without the flush lock
> held, yet the callers make the assumption that after this call the
> flush lock is held. Always return with the flush lock held.
> 
> Signed-off-by: Dave Chinner <david at fromorbit.com>

Looks good,


Reviewed-by: Christoph Hellwig <hch at lst.de>

This also removes the last user of xfs_bawrite, so you might want to
kill it.




More information about the xfs mailing list