[PATCH] mkfs: don't warn about topology when mkfsing a file
Dave Chinner
david at fromorbit.com
Mon Jan 18 19:04:43 CST 2010
On Mon, Jan 18, 2010 at 01:21:53PM -0600, Eric Sandeen wrote:
> Some tests were failing for me like:
>
> QA output created by 206
> === truncate file ===
> === mkfs.xfs ===
> +warning: unable to probe device toplology for device /mnt/test/fsfile.21615
> ...
>
> I thought about filtering the tests, but ...
>
> It seems that we shouldn't even be trying to get topology for a
> plain file, should we? And then we won't warn about failure.
>
>
> Signed-off-by: Eric Sandeen <sandeen at sandeen.net>
Sound pretty sane to me.
Reviewed-by: Dave Chinner <david at fromorbit.com>
--
Dave Chinner
david at fromorbit.com
More information about the xfs
mailing list