[PATCH] mkfs: get size of device properly
hch at infradead.org
Sun Jan 17 05:40:36 CST 2010
On Fri, Jan 15, 2010 at 04:57:52PM -0600, Eric Sandeen wrote:
> Ok, one more.
> I've been having too many problems w/ xfstests today to have run
> the last patch through xfstests but should have at least run
> 032. :(
> Anyway, last change wasn't valid to test the size of a device
> node; total brain fart. After this I'm testing the hell out
> of the next patch I send, I promise!
> Test device node size properly in check_overwrite, st_size
> is only valid for regular files.
The patch looks correct to me, but it also means we now open the device
twice in check_overwrite. We might aswell use it just once and keep the
fd for the blkid probe. Anyway, probably better to put this one in
Reviewed-by: Christoph Hellwig <hch at lst.de>
Any chance you could create a xfstests regression test for this?
More information about the xfs