[PATCH 3/3] xfs: clean up inconsistent variable naming inxfs_swap_extent

Alex Elder aelder at sgi.com
Thu Jan 14 09:41:48 CST 2010


Dave Chinner wrote:
> The swap extent ioctl passes in a target inode and a temporary
> inode which are clearly named in the ioctl structure. The code
> then assigns temp to target and vice versa, making it extremely
> difficult to work out which inode is which later in the code.
> Make this consistent throughout the code.
> 
> Also make xfs_swap_extent static as there are no external users
> of the function.

All three patches in this series look good.

> Signed-off-by: Dave Chinner <david at fromorbit.com>

Reviewed-by: Alex Elder <aelder at sgi.com>

...




More information about the xfs mailing list