[PATCH 2/2] xfs: reclaim all inodes by background tree walks

Christoph Hellwig hch at infradead.org
Fri Jan 8 04:24:08 CST 2010


Looks safe to me.  I wonder whaimpact leaving the inodes around for
longer has to memory usage for inode heavy workloads, though.

>  unlock_and_requeue:
> +	/*
> +	 * We could return EAGAIN here to make reclaim rescan the inode tree in
> +	 * a short while. However, this just burns CPU time scanning the tree
> +	 * waiting for IO to complete and xfssyncd never goes back to the idle
> +	 * state. Instead, return 0 to let the next scheduled background reclaim
> +	 * attempt to reclaim the inode again.
> +	 */
>  	xfs_iflags_clear(ip, XFS_IRECLAIM);
>  	xfs_iunlock(ip, XFS_ILOCK_EXCL);
> -	return EAGAIN;
> +	return 0;

This is an unrelated change and should be a patch of it's own.




More information about the xfs mailing list