[PATCH 1/2] xfs: cleanup xfs_iunpin_wait/xfs_iunpin_nowait

Dave Chinner david at fromorbit.com
Wed Feb 17 16:57:16 CST 2010


On Wed, Feb 17, 2010 at 02:43:56PM -0500, Christoph Hellwig wrote:
> Remove the inode item pointer and ili_last_lsn checks in __xfs_iunpin_wait
> as any pinned inode is guaranteed to have them valid.  After this the
> xfs_iunpin_nowait case is nothing more than a xfs_log_force_lsn, as we
> know that the caller has already checked the pincount.
> 
> Make xfs_iunpin_nowait the new low-level routine just doing the log force
> and rewrite xfs_iunpin_wait around it.
> 
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Nice cleanup.

Reviewed-by: Dave Chinner <david at fromorbit.com>

-- 
Dave Chinner
david at fromorbit.com




More information about the xfs mailing list