[PATCH] xfs: fix xfs_fsblock_t tracing

Dave Chinner david at fromorbit.com
Tue Feb 16 22:19:10 CST 2010


On Mon, Feb 15, 2010 at 05:02:19PM -0500, Christoph Hellwig wrote:
> Using a static buffer in xfs_fmtfsblock means we can corrupt traces if
> multiple CPUs hit this code path at the same.  Just remove xfs_fmtfsblock
> for now and print the block number purely numerical.  If we want the
> NULLFSBLOCK and NULLSTARTBLOCK formatting back the best way would be
> a decoding plugin in the trace-cmd userspace command.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Reviewed-by: Dave Chinner <david at fromorbit.com>

-- 
Dave Chinner
david at fromorbit.com




More information about the xfs mailing list