[PATCH V2] xfstests: fix up fs_perms test used by 126

Christoph Hellwig hch at infradead.org
Tue Feb 9 11:53:05 CST 2010


On Tue, Feb 09, 2010 at 10:54:54AM -0600, Eric Sandeen wrote:
> Test 126 was failing intermittently for Ted & I; it seems that
> this is because we were passing an unterminated string to
> fopen for the mode; I'm not certain why this made it fail,
> but it's pretty clearly not a good thing to do, and fixing
> it fixes the test.
> 
> Rather than passing around characters, do things string-wise,
> since that is what is ultimately used in fopen().
> 
> Reported-by: Theodore Tso <tytso at mit.edu>
> Signed-off-by: Eric Sandeen <sandeen at sandeen.net>

Looks good,


Reviewed-by: Christoph Hellwig <hch at lst.de>




More information about the xfs mailing list