xfsprogs: to -DDEBUG or not to -DDEBUG?

[Eric Sandeen]

Fedora, long ago, disabled debug in the xfsprogs specfile:

http://cvs.fedoraproject.org/viewvc/F-12/xfsprogs/xfsprogs.spec?r1=1.5&r2=1.6

* Wed Apr 20 2005 Dave Jones <davej at redhat.com>
- Disable debug. (#151438)

per this bug:  https://bugzilla.redhat.com/show_bug.cgi?id=151438

referencing this email thread:

http://oss.sgi.com/archives/linux-xfs/2005-03/msg00038.html
which no longer exists (grrrr) but is probably now here:

http://oss.sgi.com/archives/xfs/2005-03/msg00416.html

Fedora still builds with -DNDEBUG, but the upstream tarball has
it on by default.  I have seen several occasions where other
distros had failing xfs_repairs which were "fixed" by disabling
debug.  I'd like to make a decision on whether DEBUG should be
on or off by default for upstream releases.  Any thoughts?

Thanks,
-Eric