[PATCH 08/10] xfs: move the inode locking outside xfs_fsync()

[Christoph Hellwig]

On Thu, Feb 04, 2010 at 10:08:33AM +1100, Dave Chinner wrote:
> On Wed, Feb 03, 2010 at 06:29:17AM -0500, Christoph Hellwig wrote:
> > On Wed, Feb 03, 2010 at 10:25:02AM +1100, Dave Chinner wrote:
> > > We have a need for a delayed write inode flush operation
> > > to be made atomically with an fsync to avoid physically
> > > writing inodes but still keeping inode buffer information
> > > up to date for bulkstat.
> > > 
> > > Move the inode locking outside xfs_fsync() to allow this to
> > > be done.
> > 
> > What's the point of the lock_flags argument?  It should always
> > be IOLOCK_SHARED, so instead of passing it in as an argument
> > I'd rather add an assert to enforce it.
> 
> Fair enough. Updated patch below.
> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david at fromorbit.com
> 
> xfs: move the inode locking outside xfs_fsync() V2
> 
> We have a need for a delayed write inode flush operation
> to be made atomically with an fsync to avoid physically
> writing inodes but still keeping inode buffer information
> up to date for bulkstat.
> 
> Move the inode locking outside xfs_fsync() to allow this to
> be done.
> 
> Version 2
> - kill the lock_flags argument and simply assert XFS_IOLOCK_SHARED
>   in xfs_fsync().

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>