[PATCH 09/10] xfs: xfs_fs_write_inode() can fail to write inodes synchronously V2

[Christoph Hellwig]

On Wed, Feb 03, 2010 at 12:07:06PM -0600, bpm at sgi.com wrote:
> Hey Christoph,
> 
> On Wed, Feb 03, 2010 at 06:27:53AM -0500, Christoph Hellwig wrote:
> > That leaves open the NFSD case thought.  I'd prefer to have that fixed
> > if possibly.  Ben, any chance you could send your patch to use fsync
> > to the nfs list ASAP?
> 
> I'll make some time to work on it.
> 
> > I think we'd be even better off to just force
> > -o wsync and disable ->write_inode entirely for NFS, any chance you
> > could test such a patch on your setup?
> 
> Sure.  IIRC, previous tests were w/ -o wsync and write_inode switched to
> fsync passing 1 for fdatasync.  I'll try this too.

-o wsync should be very similar to using ->fsync or Dave's new
->write_inode.  What the synchronous transaction does is causing a log
force, which is exactly what fsync does in case the inode is still
pinned (except not quite as optimal, but I'll send a patch for that)