[PATCH 09/10] xfs: xfs_fs_write_inode() can fail to write inodes synchronously V2
Christoph Hellwig
hch at infradead.org
Wed Feb 3 05:27:53 CST 2010
Still not entirely happy with this one. The first one is that I think
the barriers in fsync are still too heavy for the normal sync use
case. I'd be more happy with exporting the body of xfs_fsync without
the cache flushes (and a ebtter name than xfs_fsync) and use that
for write_inode.
That leaves open the NFSD case thought. I'd prefer to have that fixed
if possibly. Ben, any chance you could send your patch to use fsync
to the nfs list ASAP? I think we'd be even better off to just force
-o wsync and disable ->write_inode entirely for NFS, any chance you
could test such a patch on your setup?
Besides that the patch is missing the comment from the previous
iteration why we're still doing the delwri iflush for the sync == 1
case. I think keeping that one is important to explain the really
weird reason for it.
More information about the xfs
mailing list