[PATCH 01/12] xfs: convert log grant ticket queues to list heads

Dave Chinner david at fromorbit.com
Mon Dec 20 18:55:41 CST 2010


On Mon, Dec 20, 2010 at 06:34:58AM -0500, Christoph Hellwig wrote:
> On Mon, Dec 13, 2010 at 03:44:32PM +1100, Dave Chinner wrote:
> > -		__field(void *, reserve_headq)
> > -		__field(void *, write_headq)
> > +		__field(void *, reserveq)
> > +		__field(void *, writeq)
> 
> To repeat my question from the last review:  what's the point in logging
> this at all?  There's not much we can do with it from trace-cmd / perf
> output.  What might be more useful is a list_empty() boolean flag.

Oh, I missed that when running through all the comments. Thanks for
pointing it out again - I'll fix it this time.

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com




More information about the xfs mailing list