> +DEFINE_SPINLOCK(dio_zero_block_lock); > +LIST_HEAD(dio_zero_block_list); These two should be static. Otherwise looks good, Reviewed-by: Christoph Hellwig <hch at lst.de>