[PATCH 09/11] xfs: clean up mapping size calculation in __xfs_get_blocks

Alex Elder aelder at sgi.com
Thu Apr 29 15:32:30 CDT 2010


On Wed, 2010-04-28 at 08:28 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-iomap-cleanup-10)
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Looks good.  I do think the result of your cleanups is
cleaner looking code.  I worry (a little bit) that
some of the information embedded in some things (like
macro names, e.g. XFS_FSB_TO_B()) going away makes
the code less understandable by someone unfamiliar
with it.  Nevertheless...

Reviewed-by: Alex Elder <aelder at sgi.com>

> Index: xfs/fs/xfs/linux-2.6/xfs_aops.c
> ===================================================================





More information about the xfs mailing list