[PATCH 05/11] xfs: report iomap_bn in block base

Alex Elder aelder at sgi.com
Thu Apr 29 09:39:43 CDT 2010


On Wed, 2010-04-28 at 08:28 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-iomap-cleanup-5)
> Report the iomap_bn field of struct xfs_iomap in terms of filesystem blocks
> instead of in terms of bytes.  Shift the byte conversions into the caller,
> and replace the IOMAP_DELAY and IOMAP_HOLE flag checks with checks for
> HOLESTARTBLOCK and DELAYSTARTBLOCK.
> 
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Looks good, although iomap_bn was previously a disk address,
not a byte offset (as you suggest in your summary).  I can
fix it if you like.

Reviewed-by: Alex Elder <aelder at sgi.com>


> Index: xfs/fs/xfs/linux-2.6/xfs_aops.c
> ===================================================================
. . .




More information about the xfs mailing list