[PATCH v3] XFS: Let the broken fiemap work in query mode.

Tao Ma tao.ma at oracle.com
Wed Apr 28 09:39:09 CDT 2010


> On Wed, Apr 28, 2010 at 11:00:25AM +0800, Tao Ma wrote:
>> -	bm.bmv_count = fieinfo->fi_extents_max + 1;
>> +	bm.bmv_count = !fieinfo->fi_extents_max ? MAXEXTNUM :
>> +					fieinfo->fi_extents_max + 1;
>> +	bm.bmv_count = MIN(bm.bmv_count,
>> +			   (__s32)(PAGE_SIZE * 16 / sizeof(struct getbmapx)));
>
> I would use min_t here instead of the case, but otherwise the patch
> looks good to me
>
>
> Reviewed-by: Christoph Hellwig <hch at lst.de>

Ok, here comes the v3. Thanks for the review.

Regards,
Tao



More information about the xfs mailing list