different error messages for mkfs.xfs -ssize

[Wengang Wang]

On 10-04-22 10:18, Kinzel, David wrote:
> >-----Original Message-----
> >From: xfs-bounces at oss.sgi.com [mailto:xfs-bounces at oss.sgi.com] 
> >On Behalf Of Wengang Wang
> >Sent: Thursday, April 22, 2010 9:37 AM
> >To: xfs at oss.sgi.com
> >Cc: greg.marsden at oracle.com; joe.jin at oracle.com
> >Subject: different error messages for mkfs.xfs -ssize
> >
> >Hi experts,
> >
> >I got different error messages when provide different value for -ssize.
> >Why the error messages are different? They are different but no one is
> >containing more info than the other.
> 
> 1639         if (sectorsize < XFS_MIN_SECTORSIZE ||
> 1640             sectorsize > XFS_MAX_SECTORSIZE || sectorsize >
> blocksize) {
> 1641                 fprintf(stderr, _("illegal sector size %d\n"),
> sectorsize);
> 1642                 usage();
> 1643         }
> 
> According to the defaults:
> 
> 62 #define XFS_MIN_SECTORSIZE_LOG  9       /* i.e. 512 bytes */
> 64 #define XFS_MIN_SECTORSIZE      (1 << XFS_MIN_SECTORSIZE_LOG)
> 
> Looks like your sectorsize is not greater than XFS_MIN_SECTORSIZE
> (illegal sector size)
> 
> For 3072,
> 
> 1561                                         if (sectorsize <= 0 ||
> 1562                                             !ispow2(sectorsize))
> 1563                                                 illegal(value, "s
> sectsize");
> 
> 3072 is not a power of two (illegal value)

Yes. That are the places where different error messges are printed.
I meant If there is no more info for a message than the other, It's
better that the messages are the same.

Thanks a lot!

regards,
wengang.