[PATCH 3/5] xfs: minor odds and ends in xfs_log_recover.c

Christoph Hellwig hch at infradead.org
Fri Apr 16 12:09:00 CDT 2010


On Thu, Apr 15, 2010 at 01:17:34PM -0500, Alex Elder wrote:
> Odds and ends in "xfs_log_recover.c".  This patch just contains some
> minor things that didn't seem to warrant their own individual
> patches:
> - In xlog_bread_noalign(), drop an assertion that a pointer is
>   non-null (the crash will tell us it was a bad pointer).
> - Add a more descriptive header comment for xlog_find_verify_cycle().
> - Make a few additions to the comments in xlog_find_head().  Also
>   rearrange some expressions in a few spots to produce the same
>   result, but in a way that seems more clear what's being computed.
> 
> (Updated in response to Dave's review comments.  Note I did not
> split this patch like I said I would.)
> 
> Signed-off-by: Alex Elder <aelder at sgi.com>

Looks good,


Reviewed-by: Christoph Hellwig <hch at lst.de>




More information about the xfs mailing list