[PATCH] 125 run ftrunc with relative path

Eric Sandeen esandeen at redhat.com
Fri Apr 16 10:48:55 CDT 2010


On 04/16/2010 02:27 AM, Lukas Czerner wrote:
> From 16588d733e681954386f1b92dd6e47cfef92a207 Mon Sep 17 00:00:00 2001
> From: Lukas Czerner <lczerner at redhat.com>
> Date: Tue, 13 Apr 2010 19:34:07 +0200
> Subject: [PATCH] 125 run ftrunc with relative path
> 
> Since ftrunc is invoked with su $qa_user, it can fail when absolute path
> is not accessible to everyone.

Looks right to me.

After talking w/ you on IRC, I'll take the liberty of adding your
signed-off-by: to the patch, and check it in with my reviewed-by:

Thanks,
-Eric

> ---
>  125 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/125 b/125
> index e84109a..9a29941 100755
> --- a/125
> +++ b/125
> @@ -61,7 +61,7 @@ touch $TESTFILE
>  chmod a+rw $TESTDIR
>  chmod a+rw $TESTFILE
>  
> -su $qa_user -c "$here/src/ftrunc -f $TESTFILE"
> +su $qa_user -c "./src/ftrunc -f $TESTFILE"
>  
>  if [ "$?" != "0" ];  then
>      echo src/ftrunc returned non 0 status!




More information about the xfs mailing list