[PATCH 14/14] repair: add missing locking in scanfunc_bmap

Alex Elder aelder at sgi.com
Thu Oct 22 11:42:46 CDT 2009


Christoph Hellwig wrote:
> Make sure to protect access to the block usage tracking btree with
> the ag_lock.


Well that one was easy.  Looks good.	-Alex

> Signed-off-by: Barry Naujok <bnaujok at sgi.com>
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Reviewed-by: Alex Elder <aelder at sgi.com>

> Index: xfsprogs-dev/repair/scan.c
> ===================================================================
> --- xfsprogs-dev.orig/repair/scan.c	2009-08-20 03:16:13.000000000 +0000
> +++ xfsprogs-dev/repair/scan.c	2009-08-20 03:18:17.000000000 +0000
> @@ -235,6 +235,7 @@
>  		agno = XFS_FSB_TO_AGNO(mp, bno);
>  		agbno = XFS_FSB_TO_AGBNO(mp, bno);
> 
> +		pthread_mutex_lock(&ag_locks[agno]);
>  		state = get_bmap(agno, agbno);
>  		switch (state) {
>  		case XR_E_UNKNOWN:
> @@ -280,6 +281,7 @@
>  				state, ino, (__uint64_t) bno);
>  			break;
>  		}
> +		pthread_mutex_unlock(&ag_locks[agno]);
>  	} else  {
>  		/*
>  		 * attribute fork for realtime files is in the regular
> 
> _______________________________________________
> xfs mailing list
> xfs at oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs




More information about the xfs mailing list