2.6.31 xfs_fs_destroy_inode: cannot reclaim

Dave Chinner david at fromorbit.com
Mon Oct 19 22:40:48 CDT 2009


On Sun, Oct 18, 2009 at 11:54:26PM -0400, Christoph Hellwig wrote:
> On Mon, Oct 19, 2009 at 12:16:00PM +1100, Dave Chinner wrote:
> > > +	 * The hash lock here protects a thread in xfs_iget from racing with
> > > +	 * us on recycling the inode.  Once we have the XFS_IRECLAIM flag set
> > > +	 * it will not touch it.
> > >  	 */
> > > -	write_lock(&pag->pag_ici_lock);
> > 
> > Did you mean to remove this write_lock? The patch does not remove
> > the unlocks....
> 
> It's taken by the caller.

Ah, I guess I need to see the whole patch series, then.

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com




More information about the xfs mailing list