[PATCH] xfs: stop calling filemap_fdatawait inside ->fsync

[Alex Elder]

Christoph Hellwig wrote:
> Now that the VFS actually waits for the data I/O to complete before
> calling into ->fsync we can stop doing it ourselves.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Looks good.

Reviewed-by: Alex Elder <aelder at sgi.com>

> Index: linux-2.6/fs/xfs/linux-2.6/xfs_file.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_file.c	2009-09-26 14:09:24.933003650 -0300
> +++ linux-2.6/fs/xfs/linux-2.6/xfs_file.c	2009-09-26 14:09:46.804256831 -0300
> @@ -176,14 +176,7 @@ xfs_file_fsync(
>  	struct dentry		*dentry,
>  	int			datasync)
>  {
> -	struct inode		*inode = dentry->d_inode;
>  	struct xfs_inode	*ip = XFS_I(inode);
> -	int			error;
> -
> -	/* capture size updates in I/O completion before writing the inode. */
> -	error = filemap_fdatawait(inode->i_mapping);
> -	if (error)
> -		return error;
> 
>  	xfs_iflags_clear(ip, XFS_ITRUNCATED);
>  	return -xfs_fsync(ip);
> 
> _______________________________________________
> xfs mailing list
> xfs at oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs