[PATCH v2 2/7] xfs: simplify xfs_buf_get / xfs_buf_read interfaces

Dave Chinner david at fromorbit.com
Tue Nov 24 18:16:36 CST 2009


On Tue, Nov 24, 2009 at 01:02:23PM -0500, Christoph Hellwig wrote:
> 
> Currently these lowlevel buffer cache interfaces are highly confusing
> as we have a _flags variant of each that does actually respect the flags,
> and one without _flags which has a flags argument that gets ignored and
> overriden with a default set.  Given that very few places use the default
> arguments get rid of the duplication and convert all callers to pass the
> flags explicitly.  Also remove the now confusing _flags postfix.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Reviewed-by: Dave Chinner <david at fromorbit.com>

-- 
Dave Chinner
david at fromorbit.com




More information about the xfs mailing list