[PATCH] xfs: make several more functions static

Eric Sandeen sandeen at sandeen.net
Fri Nov 20 09:32:48 CST 2009


Dave Chinner wrote:
> On Thu, Nov 19, 2009 at 09:52:00AM -0600, Eric Sandeen wrote:
>> Just minor housekeeping, a lot more functions can be trivially
>> made static; others could if we reordered things a bit...
> 
> Only one minor comment:
> 
>> -void
>> +STATIC_INLINE void
>>  xlog_put_bp(
>>  	xfs_buf_t	*bp)
>>  {
> 
> I'd change that as STATIC as Christoph's recent patch removed
> STATIC_INLINE. gcc will inline it for us if it's a win....

Oops, ok, thanks for looking at it.

-Eric

> Cheers,
> 
> Dave.




More information about the xfs mailing list