[PATCH 2/7] xfs: remove xfs_buf_get / xfs_buf_read

[Dave Chinner]

On Sat, Nov 14, 2009 at 11:17:19AM -0500, Christoph Hellwig wrote:
> The two interfaces are highl confusing as they do have a flags argument
> which gets ignored and replaced with default flags.  Switch the few remaining
> callers to use xfs_buf_get_flags and xfs_buf_read_flags instead and remove
> these wrappers.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Personally I would have dropped the *_flags from the function names
as well (so everything calls xfs_buf_get() or xfs_buf_read()) but
it doesn't really matter....

>  		/*
>  		 * BNO btree root block
>  		 */
> -		bp = xfs_buf_get(mp->m_ddev_targp,
> -			XFS_AGB_TO_DADDR(mp, agno, XFS_BNO_BLOCK(mp)),
> -			BTOBB(mp->m_sb.sb_blocksize), 0);
> +		bp = xfs_buf_get_flags(mp->m_ddev_targp,
> +				XFS_AGB_TO_DADDR(mp, agno, XFS_BNO_BLOCK(mp)),
> +				BTOBB(mp->m_sb.sb_blocksize), XBF_LOCK | XBF_MAPPED);

That looks wider than 80 columns. Same for the other conversions,
too.

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com