[PATCH] xfs: reset the i_iolock lock class in the reclaim path
Christoph Hellwig
hch at infradead.org
Tue Nov 3 08:55:59 CST 2009
On Mon, Nov 02, 2009 at 03:54:02PM -0600, Alex Elder wrote:
> The comment in xfs_fs_clear_inode() is very informative, but
> it may be emphasizing a lot of detail that doesn't really
> help the reader at this spot in the code. What about wording
> something more like this:
> The iolock is used by the file system to coordinate
> reads, writes, and block truncates. Up to this point
> the lock protected concurrent accesses by users of
> the inode. But from here forward we're doing some final
> processing of the inode because we're done with it,
> and although we reuse the iolock for protection it is
> really a distinct lock class (in the lockdep sense) from
> before. To keep lockdep happy (and basically indicate
> what we are doing), we explicitly re-init the iolock here.
Fine with me. Do you want a respin or will you fix up the comment on the
fly?
More information about the xfs
mailing list