[PATCH] xfs: fix double unlock in xfs_swap_extents()
Christoph Hellwig
hch at infradead.org
Fri May 8 01:28:19 CDT 2009
The patch looks good, but a little nitpick:
On Thu, May 07, 2009 at 08:13:22PM -0500, Felix Blyakher wrote:
> out:
> kmem_free(tempifp);
> return error;
>
> +out_unlock:
> + xfs_iunlock(ip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL);
> + xfs_iunlock(tip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL);
> + goto out;
> +
> out_trans_cancel:
> xfs_trans_cancel(tp, 0);
> goto out_unlock;
this would be more readable as:
out_trans_cancel:
xfs_trans_cancel(tp, 0);
out_unlock:
xfs_iunlock(ip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL);
xfs_iunlock(tip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL);
goto out;
More information about the xfs
mailing list