[PATCH] xfstests: fix async io error handling in fsx
Christoph Hellwig
hch at infradead.org
Mon Mar 30 13:56:24 CDT 2009
On Mon, Mar 30, 2009 at 01:53:21PM -0500, Felix Blyakher wrote:
>>> + /*
>>> + * The b0rked libaio defines event.res as signed.
>>> + * However the kernel strucuture has it unsigned,
>>> + * and it's used to pass negated error value.
>>> + * Till the library is fixed use the temp var.
>>> + */
>>
>> This comment seems backwards to the patch description and the actual
>> code.
>
> Hmm, not really.
> If the libaio library would be correct (do you know whom to talk
> to and where to send a patch), the code would look like this:
Yeah, but shouldn't the comment read:
/*
* The b0rked libaio defines event.res as *unsigned*.
* However the kernel strucuture has it *signed*,
* and it's used to pass negated error value.
* Till the library is fixed use the temp var.
*/
More information about the xfs
mailing list