[PATCH 2/2] XFS: Inform the xfsaild of the push target before sleeping

Christoph Hellwig hch at infradead.org
Mon Mar 16 05:38:36 CDT 2009


This looks good to me.


Reviewed-by: Christoph Hellwig <hch at lst.de>

But looking at that area I must say I'm not happy with it in general.
There are tons of useless roundtrips l_grant_lock because we drop
it just before calling xlog_grant_push_ail which needs it for
most of it's operation, and because we acquire it just before
sv_wait just to drop it.

And the duplication between xlog_grant_log_space
xlog_regrant_write_log_space is quite ugly, too.




More information about the xfs mailing list