[XFS updates] XFS development tree branch, master, updated. v2.6.30-rc4-1247-ga81655a
xfs at oss.sgi.com
xfs at oss.sgi.com
Fri Jul 31 00:03:10 CDT 2009
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".
The branch, master has been updated
a81655a xfs: bump up nr_to_write in xfs_vm_writepage
ede5851 fs/xfs: Correct redundant test
5c04c78 xfs: reduce bmv_count in xfs_vn_fiemap
from b56063453881a6d94cf5718c6769de6e35e67753 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a81655ae5a9da16a08ba14637dc6c10217e57492
Author: Eric Sandeen <sandeen at sandeen.net>
Date: Fri Jul 31 00:02:17 2009 -0500
xfs: bump up nr_to_write in xfs_vm_writepage
VM calculation for nr_to_write seems off. Bump it way
up, this gets simple streaming writes zippy again.
To be reviewed again after Jens' writeback changes.
Signed-off-by: Christoph Hellwig <hch at infradead.org>
Signed-off-by: Eric Sandeen <sandeen at sandeen.net>
Cc: Chris Mason <chris.mason at oracle.com>
Reviewed-by: Felix Blyakher <felixb at sgi.com>
Signed-off-by: Felix Blyakher <felixb at sgi.com>
commit ede58517ca93277547a0d054728c352618212d85
Author: Julia Lawall <julia at diku.dk>
Date: Mon Jul 27 18:15:25 2009 +0200
fs/xfs: Correct redundant test
bp was tested for NULL a few lines before, followed by a return, and there
is no intervening modification of its value.
A simplified version of the semantic match that finds this problem is as
follows: (http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
expression E;
position p1,p2;
@@
if (x == NULL || ...) { ... when forall
return ...; }
... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
(
*x == NULL
|
*x != NULL
)
// </smpl>
Signed-off-by: Julia Lawall <julia at diku.dk>
Acked-by: Felix Blyakher <felixb at sgi.com>
Signed-off-by: Felix Blyakher <felixb at sgi.com>
commit 5c04c78afba4805846519f29f0b55ac8759e0d48
Author: Eric Sandeen <sandeen at sandeen.net>
Date: Sun Jul 26 21:52:01 2009 -0500
xfs: reduce bmv_count in xfs_vn_fiemap
commit 6321e3ed2acf3ee9643cdd403e1c88605d7944ba caused
the full bmv_count's worth of getbmapx structures to get
allocated; telling it to do MAXEXTNUM was a bit insane,
resulting in ENOMEM every time.
Chop it down to something reasonable, the number of slots
in the caller's input buffer. If this is too large the
caller may get ENOMEM but the reason should not be a
mystery, and they can try again with something smaller.
We add 1 to the value because in the normal getbmap
world, bmv_count includes the header and xfs_getbmap does:
nex = bmv->bmv_count - 1;
if (nex <= 0)
return XFS_ERROR(EINVAL);
Signed-off-by: Eric Sandeen <sandeen at sandeen.net>
Reviewed-by: Olaf Weber <olaf at sgi.com>
Reviewed-by: Christoph Hellwig <hch at lst.de>
Signed-off-by: Felix Blyakher <felixb at sgi.com>
-----------------------------------------------------------------------
Summary of changes:
fs/xfs/linux-2.6/xfs_aops.c | 8 ++++++++
fs/xfs/linux-2.6/xfs_iops.c | 4 ++--
fs/xfs/xfs_trans_buf.c | 4 ++--
3 files changed, 12 insertions(+), 4 deletions(-)
hooks/post-receive
--
XFS development tree
More information about the xfs
mailing list