xfs regression in linux_2.6.28, "XFS_WANT_CORRUPTED_GOTO at line 3327 of file fs/xfs/xfs_btree.c"

[Roland Eggner]

On Saturday Jan 17th 2009 at 08:25:53 Dave Chinner wrote:
> On Fri, Jan 16, 2009 at 10:08:01AM +0100, Roland Eggner wrote:
> > all 2.6.28 builds which I have tried so far are broken,
> > today tried linux_2.6.29-rc1 and got the same "XFS_WANT_CORRUPTED_GOTO .."
> > note:  SAME failure with
> > linux_2.6.28
> > linux_2.6.28-git7
> > linux_2.6.28-git9
> > linux_2.6.29-rc1
> 
> These would all appear to be 2.6.29 trees you are testing. I'm
> pretty certain of this because in the vanilla stable 2.6.28 tree
> fs/xfs/xfs_btree.c only has 914 lines in it and it has no
> WANT_CORRUPTED_GOTO() macros in it either. See here if you don't
> beleive me:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=fs/xfs/xfs_btree.c;h=cc593a84c34572211cc2ff44997457838bbe4f5d;hb=4a6908a3a050aacc9c3a2f36b276b46c0629ad91
> Linus pulled the XFS tree between -git1 and -git2, which is
> why the file now has ~3700 lines in it and the bug you are
> hitting....
Thanks for this helpful info, now with grep and wc I can check if it is a pre- or post-XFS-commit kernel:
$  wc -l fs/xfs/xfs_btree.c
914 fs/xfs/xfs_btree.c
$  grep WANT_CORRUPTED_GOTO fs/xfs/xfs_btree.c

Based on your info compiled linux_2.6.28.1 .. runs flawlessly for several days :-))
> ..
> Cheers,
> 
> Dave.

-- 
Roland Eggner